Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jellyfish-api-core): add getNodeAddress RPC #1872

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(jellyfish-api-core): add getNodeAddress RPC #1872

wants to merge 6 commits into from

Conversation

shancht
Copy link
Contributor

@shancht shancht commented Nov 25, 2022

What this PR does / why we need it: /kind feature

Which issue(s) does this PR fixes?: Adding getnodeaddresses

Usage: Fixes getnodeaddress @ Issue#48

Additional comments?: Testing In-progress

@codeclimate
Copy link

codeclimate bot commented Nov 25, 2022 •
edited
Loading

Code Climate has analyzed commit 01fa3dd and detected 0 issues on this pull request.

View more on Code Climate.

@netlify
Copy link

netlify bot commented Nov 25, 2022 •
edited
Loading

✅ Deploy Preview for jellyfishsdk ready!

Name Link
🔨 Latest commit 01fa3dd
🔍 Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/638863348e8cc600095e8e7d
😎 Deploy Preview https://deploy-preview-1872--jellyfishsdk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 25, 2022 •
edited
Loading

Codecov Report

Base: 91.18% // Head: 92.55% // Increases project coverage by +1.36% 🎉

Coverage data is based on head (01fa3dd) compared to base (7c17a13).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1872      +/-   ##
==========================================
+ Coverage   91.18%   92.55%   +1.36%     
==========================================
  Files         361      361              
  Lines       10475    10498      +23     
  Branches     1319     1321       +2     
==========================================
+ Hits         9552     9716     +164     
+ Misses        876      748     -128     
+ Partials       47       34      -13
Impacted Files Coverage Δ
packages/jellyfish-api-core/src/category/net.ts 86.66% <0.00%> (-13.34%) ⬇️
packages/whale-api-client/src/api/transactions.ts 25.00% <0.00%> (-75.00%) ⬇️
...egacy-api/src/controllers/stats/StatsController.ts 25.92% <0.00%> (-62.97%) ⬇️
apps/ocean-api/src/modules/PlaygroundModule.ts 42.30% <0.00%> (-53.85%) ⬇️
packages/whale-api-client/src/api/fee.ts 50.00% <0.00%> (-50.00%) ⬇️
...an-api-client/src/errors/ApiValidationException.ts 50.00% <0.00%> (-50.00%) ⬇️
...-api-client/src/errors/client.timeout.exception.ts 50.00% <0.00%> (-50.00%) ⬇️
packages/whale-api-client/src/api/prices.ts 26.08% <0.00%> (-47.83%) ⬇️
apps/legacy-api/src/modules/WhaleApiModule.ts 45.83% <0.00%> (-45.84%) ⬇️
...y-api/src/controllers/stats/LegacyStatsProvider.ts 47.36% <0.00%> (-45.62%) ⬇️
... and 50 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link

github-actions bot commented Nov 25, 2022 •
edited
Loading

Docker build preview for jellyfish/apps is ready!

Built with commit cdf2754

  • ghcr.io/jellyfishsdk/legacy-api:pr-1872
  • ghcr.io/jellyfishsdk/ocean-api:pr-1872
  • ghcr.io/jellyfishsdk/playground-api:pr-1872
  • ghcr.io/jellyfishsdk/status-api:pr-1872
  • ghcr.io/jellyfishsdk/whale-api:pr-1872

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:cdf2754a8967bb30d1ecb2ee7210e2df4c8a54e5
  • ghcr.io/jellyfishsdk/ocean-api:cdf2754a8967bb30d1ecb2ee7210e2df4c8a54e5
  • ghcr.io/jellyfishsdk/playground-api:cdf2754a8967bb30d1ecb2ee7210e2df4c8a54e5
  • ghcr.io/jellyfishsdk/status-api:cdf2754a8967bb30d1ecb2ee7210e2df4c8a54e5
  • ghcr.io/jellyfishsdk/whale-api:cdf2754a8967bb30d1ecb2ee7210e2df4c8a54e5

@fuxingloh
Copy link
Contributor

Also, we're using "Semantic Pull Request", you should relabel your title.

@shancht shancht changed the title Add net getNodeAddress RPC feat(jellyfish-api-core): add net getNodeAddress RPC Nov 29, 2022
@github-actions github-actions bot added the kind/feature New feature request label Nov 29, 2022
@shohamc1
Copy link
Contributor

shohamc1 commented Nov 29, 2022 •
edited
Loading

Note on the should have available nodes test - it is potentially flaky since the node discovery process might not complete in 10 seconds. Additionally the test would break if any of the mydeficha.in testnet nodes went down or changed their IP addresses.

Edit: External node dependency solved with 34d19e0

@shohamc1 shohamc1 changed the title feat(jellyfish-api-core): add net getNodeAddress RPC feat(jellyfish-api-core): add getNodeAddress RPC Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuxingloh fuxingloh fuxingloh requested changes

@canonbrother canonbrother Awaiting requested review from canonbrother canonbrother is a code owner

@ivan-zynesis ivan-zynesis Awaiting requested review from ivan-zynesis ivan-zynesis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/packages kind/feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shancht @fuxingloh @shohamc1